Sourcery Starbot ⭐ refactored enthyp/chat #15

SourceryAI · 2020-11-30T14:46:39Z

Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨

Here's your pull request refactoring your most popular Python repo.

If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch https://github.com/sourcery-ai-bot/chat master
git merge --ff-only FETCH_HEAD
git reset HEAD^

SourceryAI · 2020-11-30T14:46:40Z

chat/chat_server/db/db.py

-            else:
-                log.err('DB: password_correct CALL FAILURE: no such user in database')
-                raise failure.Failure(sqlite3.IntegrityError())
+            log.err('DB: password_correct CALL FAILURE: no such user in database')
+            raise failure.Failure(sqlite3.IntegrityError())


Function DBService.password_correct refactored with the following changes:

Remove unnecessary else after guard condition (remove-unnecessary-else)

SourceryAI · 2020-11-30T14:46:40Z

chat/chat_server/db/db.py

-        results = yield self._dbpool.runQuery(query.select_notifications, (user,))
-        return results
+        return (yield self._dbpool.runQuery(query.select_notifications, (user,)))


Function DBService.get_notifications refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2020-11-30T14:46:41Z

chat/chat_server/dispatch/dispatcher.py

-            nicks = []
-            for k, v in self.user2peer.items():
-                if v == peer:
-                    nicks.append(k)
+            nicks = [k for k, v in self.user2peer.items() if v == peer]


Function Dispatcher.remove_peer refactored with the following changes:

Convert for loop into list comprehension (list-comprehension)

SourceryAI · 2020-11-30T14:46:41Z

chat/chat_server/peer/chat_client.py

@@ -490,7 +490,6 @@ def msg_JOIN(self, message):
            else:
                if self.connected:
                    self.endpoint.no_channel(channel_name)
-            pass


Function LoggedInState.msg_JOIN refactored with the following changes:

Remove redundant pass statement (remove-redundant-pass)

SourceryAI · 2020-11-30T14:46:41Z

chat/client/gui_qt.py

-        if message.strip(" ") != "":
-            if self.client:
-                self.client.handle_input(message.strip(" "))
+        if message.strip(" ") != "" and self.client:
+            self.client.handle_input(message.strip(" "))


Function GUI.send_message refactored with the following changes:

Merge nested if conditions (merge-nested-ifs)

SourceryAI · 2020-11-30T14:46:41Z

monitor/db.py

-    conn = sqlite3.connect(app.config['DATABASE'])
-    return conn
+    return sqlite3.connect(app.config['DATABASE'])


Function connect_db refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2020-11-30T14:46:41Z

monitor/monitor.py

-    return list(set([row[1] for row in rows]))
+    return list({row[1] for row in rows})


Function extract_channels refactored with the following changes:

Replace unneeded comprehension with generator (comprehension-to-generator)

Replace list(), dict() or set() with comprehension (collection-builtin-to-comprehension)

SourceryAI · 2020-11-30T14:46:42Z

monitor/monitor.py

-    for i in range(0, len(ratings_list)):
-        for j in range(0, 6):
+    for i in range(len(ratings_list)):
+        for j in range(6):


Function history refactored with the following changes:

Replace range(0, x) with range(x) (remove-zero-from-range)

SourceryAI · 2020-11-30T14:46:42Z

monitor/monitor.py

-    for i in range(0, len(ratings_list)):
-        for j in range(0, 6):
+    for i in range(len(ratings_list)):
+        for j in range(6):


Function channel refactored with the following changes:

Replace range(0, x) with range(x) (remove-zero-from-range)

'Refactored by Sourcery'

c670d72

SourceryAI commented Nov 30, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sourcery Starbot ⭐ refactored enthyp/chat #15

Sourcery Starbot ⭐ refactored enthyp/chat #15

SourceryAI commented Nov 30, 2020

SourceryAI Nov 30, 2020

SourceryAI Nov 30, 2020

SourceryAI Nov 30, 2020

SourceryAI Nov 30, 2020

SourceryAI Nov 30, 2020

SourceryAI Nov 30, 2020

SourceryAI Nov 30, 2020

SourceryAI Nov 30, 2020

SourceryAI Nov 30, 2020

		return list(set([row[1] for row in rows]))
		return list({row[1] for row in rows})

Sourcery Starbot ⭐ refactored enthyp/chat #15

Are you sure you want to change the base?

Sourcery Starbot ⭐ refactored enthyp/chat #15

Conversation

SourceryAI commented Nov 30, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment